fix/fuzz: output int32(v)/rune(q) in failing log #58827
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fuzz testing outputs failing input into testdata/<log>, it needs to marshal the input, In go, int32 and rune are the same datatype, so it cannot differentiate the two types in typeswitch. Before, when the data is a valid unicode point, it will outputs `rune(%q)` in the log, but the real datatype maybe a int32. In this case, we have to query the ASCII or unicode table to get the int32 value. It's inconvenient. So, here we output `int32(%v)/rune(%q)` to solve this. close golang#58824
Contributor
|
This PR (HEAD: a38e4ec) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/472815 to see it. Tip: You can toggle comments from me using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fuzz testing outputs failing input into testdata/, it needs to
marshal the input, In go, int32 and rune are the same datatype, so it
cannot differentiate the two types in typeswitch.
Before, when the data is a valid unicode point, it will outputs rune(%q)
in the log, but the real datatype maybe a int32. In this case, we have
to query the ASCII or unicode table to get the int32 value. It's
inconvenient.
So, here we output int32(%v)/rune(%q) to solve this.
Fixes #58824.