Skip to content

net/http/httptrace: document composition policy of ClientTrace hooks #76669

@dxasu

Description

@dxasu

There is a function Got1xxResponse in ClientTrace that returns error. In the function compose, the return value of Got1xxResponse will be ignored. Is this intentional or a bug? If it is not a bug, whether it should be explained in the comment.

newFunc := reflect.MakeFunc(hookType, func(args []reflect.Value) []reflect.Value {

		newFunc := reflect.MakeFunc(hookType, func(args []reflect.Value) []reflect.Value {
			tfCopy.Call(args)
			return of.Call(args)
		})

Metadata

Metadata

Assignees

No one assigned

    Labels

    DocumentationIssues describing a change to documentation.NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions