-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Open
Labels
DocumentationIssues describing a change to documentation.Issues describing a change to documentation.NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Description
There is a function Got1xxResponse in ClientTrace that returns error. In the function compose, the return value of Got1xxResponse will be ignored. Is this intentional or a bug? If it is not a bug, whether it should be explained in the comment.
go/src/net/http/httptrace/trace.go
Line 202 in 509ddf3
| newFunc := reflect.MakeFunc(hookType, func(args []reflect.Value) []reflect.Value { |
newFunc := reflect.MakeFunc(hookType, func(args []reflect.Value) []reflect.Value {
tfCopy.Call(args)
return of.Call(args)
})
Metadata
Metadata
Assignees
Labels
DocumentationIssues describing a change to documentation.Issues describing a change to documentation.NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.