-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Open
Labels
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.gopls/memory-corruption"can't happen" gopls crashes (races, unsafe, miscompile, runtime bugs, faulty HW)"can't happen" gopls crashes (races, unsafe, miscompile, runtime bugs, faulty HW)gopls/telemetry-wins
Milestone
Description
#!stacks
"sigpanic" && "utf8.DecodeRune:+5"
Issue created by stacks.
Blatant memory corruption:
func DecodeRune(p []byte) (r rune, size int) {
n := len(p)
if n < 1 {
return RuneError, 0
}
p0 := p[0] // <--- SEGVI wonder whether there is any point to creating new issues for cases like this that are clearly just symptoms of the same problem peppering the entire code base at random like a cloud of gunshot. Weirdly though, we got two reports of near-identical crashes within the same 24 hour period, just as we did with #76254.
This stack z3MN_w was reported by telemetry:
crash/crashruntime.gopanic:+69,+0x167go/parser.ParseFile.func1:+5,+0x3d7runtime.gopanic:+50,+0x131runtime.panicmem:=262,+0x197runtime.sigpanic:+9,+0x167unicode/utf8.DecodeRune:+5,+0x16go/scanner.(*Scanner).next:+13,+0xa4go/scanner.(*Scanner).Scan:+35,+0xd6go/parser.(*parser).next0:+18,+0x184go/parser.(*parser).next:+4,+0x64go/parser.(*parser).parseOperand:+12,+0x17ago/parser.(*parser).parsePrimaryExpr:+6,+0x132go/parser.(*parser).parseUnaryExpr:+68,+0x39dgo/parser.(*parser).parseBinaryExpr:+6,+0x149go/parser.(*parser).parseExpr:+5,+0xd4go/parser.(*parser).parseValue:+9,+0x118go/parser.(*parser).parseElement:+5,+0xe4
golang.org/x/tools/gopls@v0.20.0 go1.24.6 windows/amd64 vscode (1)
Dups: 5l7xNA
Metadata
Metadata
Assignees
Labels
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.gopls/memory-corruption"can't happen" gopls crashes (races, unsafe, miscompile, runtime bugs, faulty HW)"can't happen" gopls crashes (races, unsafe, miscompile, runtime bugs, faulty HW)gopls/telemetry-wins