Go 1.8.5 release status

PROBLEMS WITH RELEASE

• go1.8.5 tag already exists in Go repository!

Issues with fixes

• cmd/internal/obj/x86: backport "cmd/internal/obj/x86: use LEAx rather than ADDx" to 1.8 branch #20226 cmd/internal/obj/x86: backport "cmd/internal/obj/x86: use LEAx rather than ADDx" to 1.8 branch
  • CL 70871 per rsc;
• cmd/compile: corrupted value #20530 cmd/compile: corrupted value
  • CL 37154 per rsc;
  • CL 44430 per rsc;
  • CL 70841 per rsc;
• doc: go1.8.txt #20591 doc: go1.8.txt
  • CL 45015 per rsc;
• cmd/link: request backport for ppc64le linker fix to go 1.8 #20670 cmd/link: request backport for ppc64le linker fix to go 1.8
  • CL 70837 per rsc;
• runtime: usleep() does not work on Linux 386 [Go 1.8] #21520 runtime: usleep() does not work on Linux 386 [Go 1.8]
  • CL 56850 per rsc;
• crypto/x509: intermediates with unknown critical extensions not rejected [Go1.8] #22261 crypto/x509: intermediates with unknown critical extensions not rejected [Go1.8]
  • CL 70842 per rsc;
• net/smtp: let NewClient detect TLS connections [Go1.8] #22271 net/smtp: let NewClient detect TLS connections [Go1.8]
  • CL 68470 per rsc;
• cmd/go: non-Git repository failures [Go1.8] #22272 cmd/go: non-Git repository failures [Go1.8]
  • CL 69670 per rsc;
• cmd/go: fix TestImportMain not to write to current directory [Go 1.8] #22273 cmd/go: fix TestImportMain not to write to current directory [Go 1.8]
  • CL 71410 per rsc;
• net: windows tests fail due to changes to getmac [Go 1.8] #22276 net: windows tests fail due to changes to getmac [Go 1.8]
  • CL 41395 per rsc;
• net: tests using timer fail on macOS High Sierra 10.13 / iOS 11 [Go 1.8] #22279 net: tests using timer fail on macOS High Sierra 10.13 / iOS 11 [Go 1.8]
  • CL 66491 per rsc;
  • CL 67350 per rsc;
• net/http: TestLinuxSendfile hanging on linux-arm64 releaselet #22364 net/http: TestLinuxSendfile hanging on linux-arm64 releaselet
  • CL 38633 per rsc;
• doc: document Go 1.8.5 #22433 doc: document Go 1.8.5
  • CL 73392 per rsc;

Changes on release branch

• CL missing for cherry-pick of CL 37154 (for cmd/compile: corrupted value #20530)
• CL missing for cherry-pick of CL 38633 (for net/http: TestLinuxSendfile hanging on linux-arm64 releaselet #22364)
• CL missing for cherry-pick of CL 41395 (for net: windows tests fail due to changes to getmac [Go 1.8] #22276)
• CL missing for cherry-pick of CL 44430 (for cmd/compile: corrupted value #20530)
• CL missing for cherry-pick of CL 45015 (for doc: go1.8.txt #20591)
• CL missing for cherry-pick of CL 56850 (for runtime: usleep() does not work on Linux 386 [Go 1.8] #21520)
• CL missing for cherry-pick of CL 66491 (for net: tests using timer fail on macOS High Sierra 10.13 / iOS 11 [Go 1.8] #22279)
• CL missing for cherry-pick of CL 67350 (for net: tests using timer fail on macOS High Sierra 10.13 / iOS 11 [Go 1.8] #22279)
• CL missing for cherry-pick of CL 68470 (for net/smtp: let NewClient detect TLS connections [Go1.8] #22271)
• CL missing for cherry-pick of CL 69670 (for cmd/go: non-Git repository failures [Go1.8] #22272)
• CL missing for cherry-pick of CL 70837 (for cmd/link: request backport for ppc64le linker fix to go 1.8 #20670)
• CL missing for cherry-pick of CL 70841 (for cmd/compile: corrupted value #20530)
• CL missing for cherry-pick of CL 70842 (for crypto/x509: intermediates with unknown critical extensions not rejected [Go1.8] #22261)
• CL missing for cherry-pick of CL 70871 (for cmd/internal/obj/x86: backport "cmd/internal/obj/x86: use LEAx rather than ADDx" to 1.8 branch #20226)
• CL missing for cherry-pick of CL 71410 (for cmd/go: fix TestImportMain not to write to current directory [Go 1.8] #22273)
• CL missing for cherry-pick of CL 73392 (for doc: document Go 1.8.5 #22433)

Log

2017/10/26 17:06:10 starting
2017/10/26 17:06:11 working in /Users/rsc/go-releasebot-work/go1.8.5
2017/10/26 17:06:11 $ git fetch origin master
2017/10/26 17:06:14 $ git fetch origin release-branch.go1.8
2017/10/26 17:06:18 $ git clone --reference /Users/rsc/go-releasebot-work/go1.8.5/gitmirror -b release-branch.go1.8 https://go.googlesource.com/go /Users/rsc/go-releasebot-work/go1.8.5/gitwork
2017/10/26 17:06:27 $ git change relwork
2017/10/26 17:06:27 $ git config gc.auto 0
2017/10/26 17:06:27 $ git rev-parse go1.8.5
2017/10/26 17:06:27 already released
2017/10/26 17:06:27 

PANIC: already released

goroutine 71 [running]:
runtime/debug.Stack(0xc420ca9908, 0x151eaa0, 0xc420ba61e0)
	/Users/rsc/go1.9/src/runtime/debug/stack.go:24 +0xa7
main.(*Work).recover(0xc420b92240)
	/Users/rsc/src/golang.org/x/build/cmd/releasebot/main.go:194 +0x71
panic(0x151eaa0, 0xc420ba61e0)
	/Users/rsc/go1.9/src/runtime/panic.go:491 +0x283
log.(*Logger).Panic(0xc4209e6410, 0xc420ca9b10, 0x1, 0x1)
	/Users/rsc/go1.9/src/log/log.go:216 +0xbe
main.(*Work).gitCheckout(0xc420b92240)
	/Users/rsc/src/golang.org/x/build/cmd/releasebot/git.go:67 +0xa93
main.(*Work).doRelease(0xc420b92240)
	/Users/rsc/src/golang.org/x/build/cmd/releasebot/main.go:265 +0x3ab
main.main.func1(0xc420a67810, 0xc420b92240)
	/Users/rsc/src/golang.org/x/build/cmd/releasebot/main.go:99 +0x51
created by main.main
	/Users/rsc/src/golang.org/x/build/cmd/releasebot/main.go:97 +0x4c4

— golang.org/x/build/cmd/releasebot, Oct 26 21:06:27 UTC