rect.CapBound: Fix for tall and wide rects #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tall (>90 degrees) and wide (>180 degrees) lat/lng rects, rect.CapBound returned an incorrect cap that didn't contain the full rect. The function intends to return a polar cap in this case, but due to an apparent typo (2 * Pi instead of Pi), returned a cap centered at the center of the rect instead. This fix has recently been applied to C++ and Java in google3, but has not been exported to those github repos yet.
rsned
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tall (>90 degrees) and wide (>180 degrees) lat/lng rects, rect.CapBound returned an incorrect cap that didn't contain the full rect. The function intends to return a polar cap in this case, but due to an apparent typo (2 * Pi instead of Pi), returned a cap centered at the center of the rect instead.
This fix has recently been applied to C++ and Java in google3, but has not been exported to those github repos yet.