cell.ContainsPoint: Increase expansion of uv bound #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure `CellFromCellID(cellIDFromPoint(p)).ContainsPoint(p)` is always true. Increase the expansion from `dblEpsilon` to `(1.125 + dblEpsilon) * dblEpsilon`, which allows the tests to pass. @ericveach is looking into why the original bound of `dblEpsilon` does not hold. For now, fix the flaky test and we can do more later. google/s2geometry#463 (comment)
rsned
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
CellFromCellID(cellIDFromPoint(p)).ContainsPoint(p)is always true.Increase the expansion from
dblEpsilonto(1.125 + dblEpsilon) * dblEpsilon, which allows the tests to pass.@ericveach is looking into why the original bound of
dblEpsilondoes not hold. For now, fix the flaky test and we can do more later.google/s2geometry#463 (comment)