modules: Improve error checking #14014
Conversation
1. Validate combination of module path and version 2. Capture and display error messages from JSON sent to stdout 3. Remove invalid semver from mod_vendor__versions.txt testscript Closes gohugoio#14010
jmooring
force-pushed
the
improve-module-path-version-error-14010
branch
from
10a9426 to
4460b0f
Compare
|
|
||
| // Validate the combination of module path and version. | ||
| if moduleImport.Version != "" { | ||
| err := module.Check(moduleImport.Path, moduleImport.Version) |
There was a problem hiding this comment.
I understand this i a draft, and I'm not totally sure what the above check does, but for version when path points to a non-Go-module, a path that does not end with /v2 may point at a v2.0.0 version. I tested this earlier today with:
There was a problem hiding this comment.
Yeah, still looking into this. The intent is to prevent invalid semvers and invalid path/semver pairs such as:
path = "github.com/user/project/v3"
version = 'v42.6.7'
path points to a non-Go-module
Thanks. I will probably use https://github.com/bep/hugomodnogomod in an integration test unless this is a temporary repo.
There was a problem hiding this comment.
unless this is a temporary repo.
I will let it live, I will probably have a use for it myself some day.
There was a problem hiding this comment.
Note to self: there isn't a simple and reliable way to verify that the combination of a module path and version query is semantically correct before attempting to get, list, etc.
2 participants
Remove invalid semver from mod_vendor__versions.txt testscript(Need to investigate:module.Checkreports that<=v6.7.42is "not a semantic version". That is true, but it is a valid semantic version comparison per the Go docs.)Closes #14010