Skip to content

livereload: Close connection on pageshow #13290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

livereload: Close connection on pageshow #13290

wants to merge 1 commit into from

Conversation

@bep
Copy link
Member

@bep bep commented Jan 21, 2025 •
edited
Loading

Note that this PR doesn't fully fix the issue, as in

  • LiveReload.connector.disconnect() on pagehide fixes the problem.
  • But I have not found a way to "restart" the websocket connection, which means that the LiveReload stops working.
  • Note that if you make any changes to the JS, run go generate ./livereload/gen.

Fixes #13287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@bep