tpl: modify file system in os functions #13189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All os functions now operate under a common file system composed of workdir fs and overlay mount fs with fallback to contentDir for ReadFile, FileExists and Stat function. This allows to access union file system without introducing new functions and resolves issue with Stat/ReadDir working on different filesystms. Add the file system access the implementation of: Readdir for rootMappingDir and Size for dirNameOnlyFileInfo. Fix implementation of collectDirEntries for RootMappingFs to handle root directory correctly. Fixes: gohugoio#12321 gohugoio#11917 gohugoio#9604
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All os functions now operate under a common file system composed of workdir fs and overlay mount fs with fallback to contentDir for ReadFile, FileExists and Stat function.
This allows to access union file system without introducing new functions and resolves issue with Stat/ReadDir working on different filesystms.
Add the file system access the implementation of: Readdir for rootMappingDir and Size for dirNameOnlyFileInfo.
Fix implementation of collectDirEntries for RootMappingFs to handle root directory correctly.
Releated issues: #12321 #11917 #9604
Access to UFS can be done by partials https://github.com/rymut/hugo-turing/tree/4dea11eb15374325acff1c5203789ee51edec84a/hugo-turing-ufs - but it is cumbersome, so i tried to resolve the issue in hugo code without introducing new parameters or braking chanegs.