Skip to content

Conversation

@trulede
Copy link
Contributor

@trulede trulede commented Jan 19, 2026

When merging a taskfile, retain the taskfile silent value, when set true, by applying that value to all merged tasks.

fixes #1319

Test case to follow.

@trulede trulede marked this pull request as ready for review January 20, 2026 18:28
@vmaerten
Copy link
Member

The issue with this approch is slient: false does not work anymore :

  hello-not-silent:
    silent: false
    cmds:
      - echo "Hello from include not silent task"

I took a look back in time, and figure out it'll be hard to solve this issue without the scoping.
(FYI, I'm going open a new experiment soon about scoped taskfiles)

@trulede
Copy link
Contributor Author

trulede commented Jan 20, 2026

@vmaerten I added a commit which handles that by parsing YAML into a *bool. But if you are going to change the merging with scoped taskfiles then its not worth the bother here.

@vmaerten vmaerten changed the title Retain imported taskfile silent value for merged tasks. Jan 25, 2026
@vmaerten vmaerten self-requested a review January 25, 2026 15:28
Copy link
Member

@vmaerten vmaerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
I've just extract an helper

@vmaerten vmaerten merged commit f672076 into go-task:main Jan 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants