Skip to content

better Int.abs() and test coverage #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbinet merged 3 commits into from
Feb 7, 2022
Merged

better Int.abs() and test coverage #156

sbinet merged 3 commits into from
Feb 7, 2022

Conversation

@drew-512
Copy link
Contributor

@drew-512 drew-512 commented Feb 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #156 (3e7147a) into master (3068cb5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   74.55%   74.58%   +0.02%     
==========================================
  Files          64       64              
  Lines       11187    11186       -1     
==========================================
+ Hits         8341     8343       +2     
+ Misses       2297     2295       -2     
+ Partials      549      548       -1
Impacted Files Coverage Δ
py/int.go 77.81% <100.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3068cb5...3e7147a. Read the comment docs.
sbinet
sbinet reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the below nitpick.
sbinet
sbinet approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sbinet sbinet merged commit cd69d37 into go-python:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@drew-512 @sbinet