Skip to content

fix: guard against result.action being undefined #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marionebl wants to merge 3 commits into
base: main-enterprise
Choose a base branch
from
Open

fix: guard against result.action being undefined #858

marionebl wants to merge 3 commits into from

Conversation

@marionebl
Copy link

@marionebl marionebl commented Jul 3, 2025

I've observed the following recurring exception in handling check_run events. The stack trace indicates we're trying to read from action when it isn't defined. |

This accepts potentially partial check messages instead of crashing the event processing.

    TypeError: Cannot read properties of undefined (reading 'additions')
       ~~~~~ redacted ~~~~~
        at Array.reduce (<anonymous>)
        at _Settings.handleResults ( ~~~~~ redacted ~~~~~)
@marionebl
fix: guard against result.action being undefined
35772ba 
I've observed the following recurring exception in handling `check_run` events. The stack trace indicates we're trying to read from `action` when it isn't defined. |

This accepts potentially partial check messages instead of crashing the event processing. 

```
    TypeError: Cannot read properties of undefined (reading 'additions')
       ~~~~~ redacted ~~~~~
        at Array.reduce (<anonymous>)
        at _Settings.handleResults ( ~~~~~ redacted ~~~~~)
```
@marionebl marionebl mentioned this pull request Jul 7, 2025
Open
@marionebl
Copy link
Author

marionebl commented Jul 14, 2025

@decyjphr could you have a look at this bugfix?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@marionebl @decyjphr