Make Dependencies folder only be excluded in root for Swift.gitignore #3435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `Dependencies/` folder exclusion to support Accio was also excluding any folder across the project with the same name. This change makes it only exclude that folder from root of the repo.
Hipska
approved these changes
Jun 11, 2020
|
This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
Previously
Dependencies/folder in exclusion to support Accio for Swift was also excluding any folder across the project with the same name. This change makes it only exclude that folder from root of the repo.Links to documentation supporting these rule changes:
Accio creates a folder called
Dependencieshttps://github.com/JamitLabs/Accio that doesn't need to be checked in.