Skip to content

fix: reject mismatched owner IDs during validation - #228

Open
jay23606 wants to merge 2 commits into
github:mainfrom
jay23606:fix/211-owner-id-validation
Open

jay23606 wants to merge 2 commits into
github:mainfrom
jay23606:fix/211-owner-id-validation

Conversation

@jay23606

Copy link
Copy Markdown

Summary

A lockfile whose owner_id changes while owner/repo remains unchanged now produces a blocking owner-id-changed finding. The CLI reports it and prevents pinning/remediation from treating the action as verified. Repository transfers that change the canonical name continue to use the existing repo-renamed warning.

Design choice: Treating a same-name owner identity mismatch as blocking follows the issue's expectation that the lockfile is invalid and the maintainer's note that stricter validation is appropriate. The alternative is to keep accepting the mismatch; this change instead preserves the transfer case when the repository name also changes.

Fixes #211

Validation

  • Regression test on clean base 4f01e43: failed because the mismatch produced no finding.
  • Same regression test on this branch: passed.
  • go test ./internal/pipeline/... ./cmd/gh-actions-lock/format: passed.
  • go vet ./..., gofmt -l, and git diff --check: passed.
  • go test ./... fails on both base and this branch in symlink tests because Windows reports A required privilege is not held by the client; no other packages failed.
  • go test -race was not verified: this Windows Go environment has CGO disabled, and Go is unavailable in WSL.

🤖 Generated with Claude Code

@jay23606
jay23606 requested a review from a team as a code owner October 22, 2026 00:31
Copilot AI max review requested due to automatic review settings October 22, 2026 00:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

jay23606 and others added 2 commits October 22, 2026 04:28
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Signed-off-by: Jay <jay23606@users.noreply.github.com>
@jay23606
jay23606 force-pushed the fix/211-owner-id-validation branch from 8fed895 to 733a499 Compare October 22, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants