Skip to content

Warn on fresh tags when a cooldown is configured - #224

Merged
nodeselector merged 2 commits into
mainfrom
nodeselector-warn-fresh-tags-with-cooldown
Oct 22, 2026
Merged

nodeselector merged 2 commits into
mainfrom
nodeselector-warn-fresh-tags-with-cooldown

Conversation

@nodeselector

Copy link
Copy Markdown
Collaborator
  • A configured cooldown (Dependabot github-actions or user config) used to silence the fresh-tag nudge, on the assumption that resolution had already filtered fresh releases. It hadn't: nothing applied the cooldown. The nudge now always runs and uses the action's cooldown as its freshness window, with wording that names the configured days. It stays non-blocking; exit codes are unchanged.
  • Removes the unused cooldown filter (LatestStableTag, CuratePickerTags, isTagTooNew, PickerTag) and the Lister's cooldown field.

Refs #132

Cooldown never filtered pin selection; its only consumers were dead.
The fresh-tag nudge skipped actions with a cooldown on that false
assumption, so configuring one silenced the warning. Use the cooldown
as the freshness window instead and remove the unused filter code.

Refs #132

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings October 21, 2026 21:13
@nodeselector
nodeselector requested a review from a team as a code owner October 21, 2026 21:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

1 open issue
What changed in this PR

This PR updates how “fresh-tag” findings are generated: Dependabot cooldown is no longer used to filter tag selection, but instead defines the warning window and messaging for the fresh-tag informational nudge.

Changes:

  • Remove tag cooldown-based filtering logic from the tag lister and related unit tests.
  • Update fresh-tag warning logic and tests to warn within configured cooldowns (with revised wording).
  • Adjust integration scenario naming/expectations to reflect new fresh-tag behavior.
File Description
test/​scenarios/​catalog.yml Updates the cooldown scenario to expect a fresh-tag warning (and new wording) inside cooldown.
test/​integration/​run.rb Renames/wires the updated scenario name/token and updates related comments.
internal/​tag/​testing.go Updates test helper to match the simplified NewLister signature.
internal/​tag/​tags.go Removes cooldown config from Lister and deletes cooldown-based filtering helpers.
internal/​tag/​tagging.go Removes picker-related types/helpers that depended on cooldown filtering.
internal/​tag/​pure_test.go Deletes tests for removed cooldown filtering (isTagTooNew).
internal/​tag/​cooldown.go Updates package and type docs to reflect cooldown as a warning window, not a filter.
internal/​pipeline/​checks/​category.go Updates FreshTag category docs to match new semantics.
cmd/​gh-actions-lock/​run.go Stops passing cooldown into the lister; updates comments about cooldown semantics.
cmd/​gh-actions-lock/​freshtag_test.go Reworks tests to validate fresh-tag behavior with/without configured cooldown.
cmd/​gh-actions-lock/​fresh_tag.go Implements cooldown-aware fresh-tag window and message variants.

Review effort: Lite

Comment thread cmd/gh-actions-lock/fresh_tag.go Resolved
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@nodeselector
nodeselector merged commit 4f01e43 into main Oct 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants