Skip to content

Add the overwrite flag when init-ing databases #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add the overwrite flag when init-ing databases #2229

merged 1 commit into from
Apr 8, 2024

Conversation

@aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Apr 5, 2024 •
edited by angelapwen
Loading

This ensures that if there is a database already in the filesystem, we can gracefully handle creating a new one. This sometimes happens when a user is on a self-hosted runner and neglects to clean state across runs.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.
@aeisenberg aeisenberg requested a review from angelapwen April 5, 2024 21:50
@aeisenberg aeisenberg requested a review from a team as a code owner April 5, 2024 21:50
@aeisenberg aeisenberg force-pushed the aeisenberg/add-overwrite branch from f7ee3b1 to 151524e Compare April 5, 2024 21:52
@aeisenberg
Add the overwrite flag when init-ing databases
4a666f8 
This ensures that if there is a database already in the filesystem, we
can gracefully handle creating a new one. This sometimes happens when
a user is on a self-hosted runner and neglects to clean state across
runs.
@aeisenberg aeisenberg force-pushed the aeisenberg/add-overwrite branch from 151524e to 4a666f8 Compare April 5, 2024 22:02
angelapwen
angelapwen approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
@aeisenberg aeisenberg merged commit 24a95a0 into main Apr 8, 2024
@aeisenberg aeisenberg deleted the aeisenberg/add-overwrite branch April 8, 2024 17:38
This was referenced Apr 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@aeisenberg @angelapwen