Replacement of COBOL sample#7696
Open
AntonioGibas wants to merge 4 commits intogithub-linguist:mainfrom
Open
Conversation
Per the contribution guidelines, "Hello World" examples are discouraged as they don't provide enough tokens for the classifier to accurately detect the language. I am proposing a replacement with a more representative example that demonstrates core COBOL features widely used in legacy systems.
'"Hello world" examples will not be accepted'
Delete samples/COBOL/hello_world.cbl
Add Fibonacci sequence generator and analyzer program
lildude
requested changes
Dec 7, 2025
Member
lildude
left a comment
lildude
left a comment
There was a problem hiding this comment.
Add Fibonacci sequence generator and analyzer program
If you're going to remove samples in the name of adhering to the guidelines, you should be adding a real-world sample. Fibonacci examples are just like "Hello world" samples in that no one really uses these outside of learning the language.
The PR template should also point to the source of the real-world sample and state the license of the sample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing samples/COBOL/hello_world.cbl, replacing it with example that covers more language usage
Description
Reason for removal:
The repository rules have been updated and explicitly state that generic 'Hello World' examples are not allowed within the samples directory. This commit ensures the COBOL section is compliant with the repository's current guidelines.
Relevant commit:
Checklist:
I have included a real-world usage sample for all extensions added in this PR:
I have included a change to the heuristics to distinguish my language from others using the same extension.
I am fixing a misclassified language