Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Support partial exc_info using logger #1132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maruno
Copy link

@maruno maruno commented Nov 8, 2017

In our application we were logging exceptions that have been captured and saved. To enter these we use the tri-tuple exc_info format. The framework we use that captures these exceptions (graphql-core) provides us with the exception information missing the stack. Sentry would log something but totally skip the exception information.

This change checks if all the exc_info is (None, None, None) or tries to parse the partial exc_info, still providing the exception class and message in the Sentry event

@ashwoods ashwoods self-requested a review November 12, 2017 19:29
@ashwoods ashwoods self-assigned this Nov 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants