WIP: Add Sending Mail Possibility to Mesh #1357
Conversation
| @@ -137,6 +137,18 @@ public abstract class MeshOptions implements Option { | |||
| @EnvironmentVariable(name = MESH_MAX_PURGE_BATCH_SIZE, description = "Override the maximum purge batch size.") | |||
| private int versionPurgeMaxBatchSize = 10; | |||
|
|
|||
| public MailOptions getMailOptions() { | |||
There was a problem hiding this comment.
Please use @JsonProperty("mail") or similar.
| @@ -137,6 +137,18 @@ public abstract class MeshOptions implements Option { | |||
| @EnvironmentVariable(name = MESH_MAX_PURGE_BATCH_SIZE, description = "Override the maximum purge batch size.") | |||
| private int versionPurgeMaxBatchSize = 10; | |||
|
|
|||
| public MailOptions getMailOptions() { | |||
There was a problem hiding this comment.
Please use @JsonProperty("mail") or similar.
| message.setAttachment(new ArrayList<>()); | ||
|
|
||
| // download all binary data and add as attachments | ||
| return Observable.fromIterable(fileFieldNames).flatMapSingle(name -> { |
There was a problem hiding this comment.
You can also use BinaryDao to get the binary stream asynchronously.
| message.setAttachment(new ArrayList<>()); | ||
|
|
||
| // download all binary data and add as attachments | ||
| return Observable.fromIterable(fileFieldNames).flatMapSingle(name -> { |
There was a problem hiding this comment.
You can also use BinaryDao to get the binary stream asynchronously.
|
Good work by now, thanks. Keep making it 👍 |
1 similar comment
|
Good work by now, thanks. Keep making it 👍 |
| HibJob mailSendingJob = Tx.get().jobDao().enqueueMailSending(user, new Timestamp(System.currentTimeMillis()).getTime(), ac.getBodyAsString()); | ||
|
|
||
| if(mailSendingJob.getStatus() == JobStatus.FAILED){ | ||
| Tx.get().jobDao().enqueueMailSending(user,new Timestamp(System.currentTimeMillis()).getTime() + meshOptions.getMailOptions().getRetry(), ac.getBodyAsString()); |
There was a problem hiding this comment.
Here you have to reassign mailSendingJob, in order the following status check to work.
| Tx.get().jobDao().enqueueMailSending(user,new Timestamp(System.currentTimeMillis()).getTime() + meshOptions.getMailOptions().getRetry(), ac.getBodyAsString()); | ||
| } | ||
| if (mailSendingJob.getStatus() == JobStatus.COMPLETED) { | ||
| Tx.get().jobDao().delete(mailSendingJob, new DummyBulkActionContext()); |
There was a problem hiding this comment.
And here you have to reassign it again to get the eventual status, and return it appropriately.
| import io.vertx.ext.web.FileUpload; | ||
|
|
||
| /** | ||
| * @see MicronodeMigrationContext |
There was a problem hiding this comment.
Not a micronode but a general action context.
| MailClient mailClient = MailClient.create(vertx, config); | ||
| String mail = db.tx(mailJob::getMail); | ||
|
|
||
| MailSendingRequest request = JsonUtil.readValue(mail, MailSendingRequest.class); |
There was a problem hiding this comment.
These approach of having the whole email as JSON is not that much useful. Better to send/store the mail parts distinctly, as done in the sending context. This will allow the client to fetch/filter/reuse the jobs, if required, and gives better control over sending.
There was a problem hiding this comment.
The problem is that I have also data that cannot be send in primitive data like Lists of Strings for example
| }); | ||
| }) | ||
| .lastOrError().doOnError(th-> { | ||
|
|
There was a problem hiding this comment.
Please fill the error processing.
| * @param mail | ||
| * @return | ||
| */ | ||
| HibJob enqueueMailSending(HibUser user, long now, String mail); |
There was a problem hiding this comment.
The API should also be changed accordingly, to accept distinct email parts.
There was a problem hiding this comment.
HibJob enququeMailSending(HibUser user, long time, List<String> toAddrs, List<String> ccAddrs, List<String> bccAddrs, String title, String body, List<String> attachmentUuids)
There was a problem hiding this comment.
HibJob enququeMailSending(HibUser user, long time, MailSendingRequest request)
|
|
||
| import com.gentics.mesh.core.rest.common.AbstractResponse; | ||
|
|
||
| public class MailSendingRequest extends AbstractResponse { |
There was a problem hiding this comment.
It is a response, not a request.
Abstract
Checklist
General
/CHANGELOG.adocOn API Changes