Skip to content

fix: add aria-modal=true to reveal component #12610#15527

Open
ashpsl wants to merge 1 commit intofoundation:developfrom
ashpsl:fix/accessibility-missing-attribute-on-reveal-component-12610
Open

fix: add aria-modal=true to reveal component #12610#15527
ashpsl wants to merge 1 commit intofoundation:developfrom
ashpsl:fix/accessibility-missing-attribute-on-reveal-component-12610

Conversation

@ashpsl
Copy link

@ashpsl ashpsl commented Feb 13, 2025

Description

Added aria-modal="true" to the reveal component

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@ashpsl ashpsl changed the title fix: add aria-modal=true to reveal component Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@ashpsl