Skip to content

[4.0.0-Beta1] "Save Changes" always disabled - SPI pins fail to get hidden class, fail validity checks #360

@henrygab

Description

@henrygab

--------- Instructions - Delete this ---------
Please provide answers directly below each section.
--------- Instructions - Delete to here ---------
ESPixelStick Firmware Version
4.0.0-Beta1 (7083637)

Hardware Version
ESPixelStick v3

Binary release or compiled yourself?
Binary release

Operating System
N/A

Access Point
Ubiquiti Nanostation M2 Loco

Describe the bug

Steps to repro:

  1. Load 4.0.0-Beta1 firmware onto new D1 mini
  2. goto Device Setup tab
  3. Change Primary Input to DDP (leave secondary input disabled)
  4. Change Output 1 to WS2811
  5. Click on Save Changes

Expected results:

The Save Changes button should be enabled, and thus clicking on it should save the changes.

Actual results:

The button is disabled (HTML attribute). Nothing happens when clicking on it (obviously). The configuration is not saved. Changing to other tab and back loses all changes.

Other bits and pieces

Manually removing the "disabled" attribute in Edge's DevTools (F12) allows saving the configuration.

Reviewing the page in Edge's DevTools (F12) shows the following properties that may be of interest for the save button:

  • HTMLButtonElement
    • validity: ValidityState
      • badInput: false
      • customError: false
      • patternMismatch: false
      • rangeOverflow: false
      • rangeUnderflow: false
      • stepMismatch: false
      • tooLong: false
      • tooShort: false
      • typeMismatch: false
      • valid: true
      • valueMissing: false
    • willValidate: false

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions