feat: Make execution_id and execution_domain available for plugins #6832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two new convenience methods to the TaskExecutionMetadata interface to provide direct access to execution_id and execution_domain for plugins. Previously, plugins had to traverse the nested protobuf structure to access this information. Fixes flyteorg#6308 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6832 +/- ##
==========================================
- Coverage 56.94% 56.93% -0.01%
==========================================
Files 929 929
Lines 58139 58143 +4
==========================================
+ Hits 33105 33106 +1
- Misses 21993 21996 +3
Partials 3041 3041
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6308
Summary
Adds
GetExecutionID()andGetExecutionDomain()methods to theTaskExecutionMetadatainterface, allowing plugins to access the workflow execution identifier and domain.Changes
GetExecutionID() *core.WorkflowExecutionIdentifiertoTaskExecutionMetadatainterfaceGetExecutionDomain() stringtoTaskExecutionMetadatainterfacetaskExecutionMetadatastruct using existingNodeExecutionMetadatadataTest Plan
🤖 Generated with Claude Code