Fix for doc referenced samples #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MaesterChestnut
commented
May 9, 2024
MaesterChestnut
commented
- Move samples referenced from docs so that they can install, build, and run without issues
- Add readme to docs-menu-basic sample
- Update readme for docs-menu-rag sample
MaesterChestnut
force-pushed
the
docsBasicReadme
branch
from
67c3b95 to
0dfa59f
Compare
tonybaroneee
reviewed
May 9, 2024
MaesterChestnut
force-pushed
the
docsBasicReadme
branch
from
0dfa59f to
39b9aee
Compare
added 8 commits
May 10, 2024 14:50
MaesterChestnut
force-pushed
the
docsBasicReadme
branch
from
1421b66 to
062d94b
Compare
tonybaroneee
approved these changes
May 10, 2024
js/samples/docs-menu-basic/README.md
Outdated
| cd </path/to/genkit>; pnpm run setup; cd - | ||
| ``` | ||
|
|
||
| where `</path/to/genkit>` is the top level of the genkit repo |
Collaborator
There was a problem hiding this comment.
nit: add period at the end
js/samples/docs-menu-rag/README.md
Outdated
| cd </path/to/genkit>; pnpm run setup; cd - | ||
| ``` | ||
|
|
||
| where `</path/to/genkit>` is the top level of the genkit repo |
Collaborator
There was a problem hiding this comment.
nit: add period at the end
js/samples/docs-menu-rag/README.md
Outdated
|
|
||
| ## Run setup | ||
|
|
||
| This will add the `GenkitGrubPub.pdf` to your index |
Collaborator
There was a problem hiding this comment.
nit: add colon : at the end
js/samples/docs-menu-basic/README.md
Outdated
| genkit start | ||
| ``` | ||
|
|
||
| Click on menuSuggestionFlow in the lefthand navigation panel to playground the new flow. |
Collaborator
There was a problem hiding this comment.
nit: wrap menuSuggestionFlow in backticks:
`menuSuggestionFlow`
(same in js/samples/docs-menu-rag/README.md)
js/samples/docs-menu-basic/README.md
Outdated
| genkit start | ||
| ``` | ||
|
|
||
| Click on menuSuggestionFlow in the lefthand navigation panel to playground the new flow. |
Collaborator
There was a problem hiding this comment.
nit: playground -> run
(same in js/samples/docs-menu-rag/README.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.