feat(go/plugins/firebase): add firestore retriever to go firebase plugin #791
Conversation
| t.Error("retrieved document is nil") | ||
| } | ||
| } | ||
| fmt.Printf("Doc with content \n\n %s \n\n retrieved \n\n", resp.Documents[0].Content[0].Text) |
There was a problem hiding this comment.
I'm confused: where does this test add documents to the collection?
Anyway, assuming you know the documents, you can do a little better here by checking their content, or at least part of their content (like a substring).
There was a problem hiding this comment.
I still don't see where the documents come from. If they have to be present in the DB already, add a comment explaining that.
There was a problem hiding this comment.
Yup! will sort this out, applying these changes when I can in between some js work
go/plugins/firebase/retriever.go
Outdated
|
|
||
| coll := cfg.Client.Collection(cfg.Collection) | ||
| if coll == nil { | ||
| return nil, fmt.Errorf("collection path is invalid") |
There was a problem hiding this comment.
fmt.Errorf("DefineFirestoreRetriever: collection path %q is invalid", cfg.Collection)
Also I wonder if we could call this outside the closure to check the error earlier.
| t.Error("retrieved document is nil") | ||
| } | ||
| } | ||
| fmt.Printf("Doc with content \n\n %s \n\n retrieved \n\n", resp.Documents[0].Content[0].Text) |
There was a problem hiding this comment.
I still don't see where the documents come from. If they have to be present in the DB already, add a comment explaining that.
cabljac
force-pushed
the
@invertase/firestore-retriever-go
branch
4 times, most recently
from
521a059 to
32c9d3c
Compare
cabljac
force-pushed
the
@invertase/firestore-retriever-go
branch
from
32c9d3c to
adf420a
Compare
3 participants
This PR adds a firestore retriever helper to the Go plugin
(Merge #790 first)
Resolves #711
Checklist (if applicable):