Genkit intro doc revamp #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisraygill
requested review from
i2amsam,
kevinthecheung,
mbleigh and
pavelgj
tonybaroneee
reviewed
Aug 7, 2024
mbleigh
approved these changes
Aug 7, 2024
Collaborator
mbleigh
left a comment
mbleigh
left a comment
There was a problem hiding this comment.
Only did a quick pass, but I like it better than the status quo for sure.
i2amsam
reviewed
Aug 7, 2024
i2amsam
reviewed
Aug 7, 2024
i2amsam
reviewed
Aug 7, 2024
kevinthecheung
approved these changes
Aug 7, 2024
i2amsam
reviewed
Aug 7, 2024
i2amsam
reviewed
Aug 7, 2024
i2amsam
reviewed
Aug 7, 2024
i2amsam
approved these changes
Aug 7, 2024
Contributor
i2amsam
left a comment
i2amsam
left a comment
There was a problem hiding this comment.
Nice improvement! Left some nitpicks but nothing blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamping the Genkit intro document.
See staged preview here: https://firebase.devsite.corp.google.com/docs/genkit