Update firebase peer dependencies to have a minimum version #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaroneee
approved these changes
Aug 6, 2024
andrewbrook
approved these changes
Aug 6, 2024
pavelgj
reviewed
Aug 6, 2024
Comment on lines
+43
to
+45
| "@genkit-ai/ai": "workspace:^0.5.7", | ||
| "@genkit-ai/core": "workspace:^0.5.7", | ||
| "@genkit-ai/flow": "workspace:^0.5.7" |
Collaborator
There was a problem hiding this comment.
pnpm will translate these to the latest version from the workspace:
it's not sufficient?
Contributor
Author
There was a problem hiding this comment.
That is most definitely sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Monitoring in Firebase requires a minimum version in other genkit plugins to function properly.
With this change developers will now see a warning message if a peer dependency is not met.
pnpm and workspace dependencies behave somewhat oddly with this (see pnpm/pnpm#7087), but once released it should work for vanilla npm.