Skip to content

Conversation

@MaesterChestnut
Copy link
Contributor

@MaesterChestnut MaesterChestnut commented May 7, 2024

#56

Adding a menu/basic example to link to from our docs. This will allow users to go code and immediately be able to run an example of what they just read in the docs.

image

@MaesterChestnut MaesterChestnut requested a review from schnecle May 7, 2024 18:02
Copy link
Contributor

@maxl0rd maxl0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's confusing to have this nested inside the existing sample. Could we put up a level it in it's own samples/xxxxx folder. When it supersedes the existing sample we can just remove that one?

@MaesterChestnut MaesterChestnut requested a review from maxl0rd May 8, 2024 17:34
Copy link
Contributor

@schnecle schnecle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have menu-example/basic/basic - should that just be menu-example/basic?

const llmResponse = await generate({
model: geminiPro,
prompt: `Our menu today includes burgers, spinach, and cod.
Tell me if ${subject} can be found on the menu`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 💯 on how it ties in with your broader plans, but what we discussed in-person was perhaps turning this into something more creative/generative in nature, like a menu generator, or similar.

@MaesterChestnut MaesterChestnut merged commit 039c14a into main May 9, 2024
@MaesterChestnut MaesterChestnut deleted the docSampleMenu branch May 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants