-
Notifications
You must be signed in to change notification settings - Fork 623
Elisa/feat(py)/add mcp sample test #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MengqinShen
wants to merge
4
commits into
main
Choose a base branch
from
elisa/feat(py)/add-mcp-sample-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,412
−24
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Resource types and functions for Genkit.""" | ||
|
|
||
| import re | ||
| from collections.abc import Awaitable, Callable | ||
| from typing import Any | ||
|
|
||
| from pydantic import BaseModel | ||
|
|
||
| from genkit.core.typing import Part | ||
|
|
||
|
|
||
| class ResourceOptions(BaseModel): | ||
| """Options for defining a resource. | ||
|
|
||
| Attributes: | ||
| name: The name of the resource. | ||
| uri: Optional fixed URI for the resource (e.g., "my://resource"). | ||
| template: Optional URI template with placeholders (e.g., "file://{path}"). | ||
| description: Optional description of the resource. | ||
| """ | ||
|
|
||
| name: str | ||
| uri: str | None = None | ||
| template: str | None = None | ||
| description: str | None = None | ||
|
|
||
|
|
||
| class ResourceContent(BaseModel): | ||
| """Content returned by a resource. | ||
|
|
||
| Attributes: | ||
| content: List of content parts (text, media, etc.). | ||
| """ | ||
|
|
||
| content: list[Part] | ||
|
|
||
|
|
||
| # Type for resource function | ||
| ResourceFn = Callable[[dict[str, Any]], Awaitable[ResourceContent] | ResourceContent] | ||
|
|
||
|
|
||
| def matches_uri_template(template: str, uri: str) -> dict[str, str] | None: | ||
| """Check if a URI matches a template and extract parameters. | ||
|
|
||
| Args: | ||
| template: URI template with {param} placeholders (e.g., "file://{path}"). | ||
| uri: The URI to match against the template. | ||
|
|
||
| Returns: | ||
| Dictionary of extracted parameters if match, None otherwise. | ||
|
|
||
| Examples: | ||
| >>> matches_uri_template('file://{path}', 'file:///home/user/doc.txt') | ||
| {'path': '/home/user/doc.txt'} | ||
| >>> matches_uri_template('user://{id}/profile', 'user://123/profile') | ||
| {'id': '123'} | ||
| """ | ||
| # Split template into parts: text and {param} placeholders | ||
| parts = re.split(r'(\{[\w]+\})', template) | ||
| pattern_parts = [] | ||
| for part in parts: | ||
| if part.startswith('{') and part.endswith('}'): | ||
| param_name = part[1:-1] | ||
| # Use .+? (non-greedy) to match parameters | ||
| pattern_parts.append(f'(?P<{param_name}>.+?)') | ||
| else: | ||
| pattern_parts.append(re.escape(part)) | ||
|
|
||
| pattern = f'^{"".join(pattern_parts)}$' | ||
|
|
||
| match = re.match(pattern, uri) | ||
| if match: | ||
| return match.groupdict() | ||
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These direct assignments create a strong circular reference between
prompt_actionandexecutable_prompt. While Python's garbage collector can often handle cycles, it's best practice to avoid them to prevent potential memory leaks, especially in long-running applications. I recommend using a weak reference to break the cycle.You can do this by adding
import weakrefat the top of the file and then changing line 691 to:Note that any code that accesses
_executable_promptwill then need to call it as a function to get the object:prompt_action._executable_prompt().