-
Notifications
You must be signed in to change notification settings - Fork 623
refactor(py/samples): use a central script to run samples #4021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the Python samples directory by standardizing how samples are run and organized. The core change involves introducing a central Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
be302b4 to
4a70115
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and useful refactoring by creating a centralized script, py/bin/run_sample, to execute the Python samples. This standardizes the process of running samples and simplifies the developer experience. The changes involve adding run.sh scripts to each sample, renaming main files to src/main.py, and updating documentation accordingly.
The new run_sample script is well-structured, but I have a couple of suggestions to improve its robustness and user experience. Specifically, I've commented on improving the sample discovery logic and making the automatic installation of gum less intrusive.
Overall, this is a great improvement for the project's sample ecosystem.
4a70115 to
49195b2
Compare
49195b2 to
75ac1e7
Compare
Uh oh!
There was an error while loading. Please reload this page.