-
Notifications
You must be signed in to change notification settings - Fork 623
fix:(js/core/schema): Allow disabling runtime schema compilation #3988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ssbushi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances Genkit's schema validation system by introducing a configurable mechanism to disable runtime schema compilation. This is particularly beneficial for environments with strict security policies, such as CloudFlare Workers, where dynamic code generation is restricted. By integrating an interpretive JSON schema validator, the system can now operate effectively in these constrained environments while maintaining robust schema validation capabilities. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature to disable schema code generation at runtime, primarily for environments like CloudFlare workers that restrict eval or new Function. This is implemented by adding a disableSchemaCodeGeneration() function that switches the validation mode from 'compile' (using ajv.compile) to 'interpret' (using the newly added @cfworker/json-schema library). The validateSchema function was updated with conditional logic to support this new mode, including new error detail conversion functions for Zod and @cfworker/json-schema. The package.json and pnpm-lock.yaml files were updated to include the new dependency. Initial test cases were added to verify the disableSchemaCodeGeneration functionality for JSON schemas. However, the review comments point out a flaw where Zod's native safeParse is prioritized over the 'interpret' mode, even when code generation is disabled, defeating the purpose for Zod schemas. A suggestion is made to adjust the validation logic to ensure Zod's native validation only occurs in 'compile' mode, and a new test case for Zod schemas in 'interpret' mode is requested to prevent future regressions.
Code:
Fixes: #3968
Checklist (if applicable):