Skip to content

Conversation

@eric642
Copy link
Contributor

@eric642 eric642 commented Sep 28, 2025

Description here... Help the reviewer by:

  • linking to an issue that includes more details
  • if it's a new feature include samples of how to use the new feature
  • (optional if issue link is provided) if you fixed a bug include basic bug details

Checklist (if applicable):

@eric642
Copy link
Contributor Author

eric642 commented Sep 28, 2025

@apascal07 please review it. Enable all action types to support dynamic plugins

@apascal07
Copy link
Collaborator

What is your use case? We use resolve for models and embedders because they can be provided by plugins dynamically. The other types are user-defined mostly so it doesn't make sense for them to call resolve instead of look up.

@eric642
Copy link
Contributor Author

eric642 commented Sep 29, 2025

I have a set of stateful tools, and I hope they can be re-instantiated when used by different agents. For example: agent as tool can be used for ReActAgent. In addition, our company has other prompt management platforms. We hope to be able to obtain the latest version of the prompt in real time through dynamic plugins.

@eric642
Copy link
Contributor Author

eric642 commented Sep 29, 2025

ResolveActionFor first performs a lookup; only if the lookup fails does it proceed to search for dynamic plugins. Therefore, I believe that using ResolveActionFor does not alter the program's behavior, while still enabling dynamic plugin functionality, and it appears to present no significant issues.

@apascal07 apascal07 changed the title fix(go): Use ResolveActionFor to support dynamic plugins Sep 29, 2025
@apascal07 apascal07 merged commit 809efb3 into firebase:main Sep 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants