[Go] make ActionType internal #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActionType is really an implementation detail. By making it internal, not only do we reduce clutter in the user-facing API, but we also make it impossible for 3P code to register any actions of a type that they shouldn't. For instance, now the only way to register an embedder is with ai.DefineEmbedder. The exception is custom actions, so we provide DefineCustomAction.
ianlancetaylor
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionType is really an implementation detail. By making it internal,
not only do we reduce clutter in the user-facing API, but we also
make it impossible for 3P code to register any actions of a type
that they shouldn't. For instance, now the only way to register an
embedder is with ai.DefineEmbedder.
The exception is custom actions, so we provide DefineCustomAction.