Skip to content

Fix(go) prompt.excute merge external incoming messages #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eric642 wants to merge 2 commits into from
Closed

Fix(go) prompt.excute merge external incoming messages #3545

eric642 wants to merge 2 commits into from

Conversation

@eric642
Copy link
Contributor

@eric642 eric642 commented Sep 11, 2025 •
edited
Loading

Fixes #3544
@eric642 eric642 changed the title Fix the additional message Sep 11, 2025
@eric642 eric642 mentioned this pull request Sep 12, 2025
Closed
apascal07
apascal07 reviewed Sep 12, 2025
View reviewed changes
go/ai/prompt.go

p.MessagesFn = mergeMessagesFn(p.MessagesFn, execOpts.MessagesFn)

input, err := buildVariables(execOpts.Input)
Copy link
Collaborator

@apascal07 apascal07 Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite see why this is necessary. Without this, we pipe through execOpts.Input to buildRequest() which does this as a first step.
apascal07
apascal07 reviewed Sep 12, 2025
View reviewed changes
go/ai/prompt.go
}
}

p.MessagesFn = mergeMessagesFn(p.MessagesFn, execOpts.MessagesFn)
Copy link
Collaborator

@apascal07 apascal07 Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to delete this line since it'll double up the messages from the prompt when we render the messages at the bottom.
@apascal07
Copy link
Collaborator

apascal07 commented Sep 12, 2025

Fix here: #3565
@apascal07 apascal07 closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix go

2 participants

@eric642 @apascal07