Skip to content

refactor(plugins/checks): migrate to v2 API #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
CorieW wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

refactor(plugins/checks): migrate to v2 API #3541

CorieW wants to merge 8 commits into from

Conversation

@CorieW
Copy link
Member

@CorieW CorieW commented Sep 10, 2025 •
edited
Loading

Resolves #3444

What this does

  • Upgrades Genkit to the latest version
  • Migrates the plugin API to v2 (doc)

Testing

  • Checked that the evaluators load with the same names/prefixes on the UI.
  • Checked that at least one evaluator works consistent with pre-migration on the UI.
  • Using an evaluator object, checked using a flow works consistent with pre-migration.
  • Using an evaluator string ('pluginName/evaluatorName'), checked using a flow works consistent with pre-migration.
  • Tested error response from embedder.
  • Tested error response from model.
@github-actions github-actions bot added the js label Sep 10, 2025
cabljac
cabljac reviewed Sep 16, 2025
View reviewed changes
cabljac
cabljac approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one small nit
@CorieW CorieW marked this pull request as ready for review September 17, 2025 13:55
cabljac
cabljac reviewed Sep 22, 2025
View reviewed changes
cabljac
cabljac reviewed Sep 29, 2025
View reviewed changes
dackers86
dackers86 reviewed Sep 30, 2025
View reviewed changes
@cabljac cabljac marked this pull request as draft October 6, 2025 08:02
cabljac
cabljac reviewed Oct 7, 2025
View reviewed changes
CorieW
CorieW commented Oct 27, 2025
View reviewed changes
js/plugins/checks/src/index.ts
await getProjectId(googleAuth, options)
),
];
},
Copy link
Member Author

@CorieW CorieW Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a resolver
@cabljac cabljac self-requested a review October 28, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

js

3 participants

@CorieW @dackers86 @cabljac