feat(go): Fix missing input schema from dynamic tools #3524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
approved these changes
Sep 8, 2025
hendrixmar
pushed a commit
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added support for dynamic tools we didn't have a way to define a dynamic tool with an input schema, so the tools weren't propagating the required arguments correctly. This PR fixes that problem.
I also noticed that for JSON schema properties that are numbers (minItems, maxItems, minimum, maximum), our googlegenai gemini plugin expects these fields to be strings and casts to float. However the JSON schemas from MCP tools get unmarshalled into jsonschema.Schema which types them as floats/ints. I think it's most flexible to support both types in the gemini plugin, so I updated that here.