fix(ai): propagate abortSignal in recursive generateHelper calls #3507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generateHelper recursively calls itself during tool iterations, the abortSignal was not being passed to the recursive call. This caused abort signals to be lost after the first tool iteration, preventing proper cancellation of long-running operations with multiple tool calls. This fix ensures abortSignal is propagated through all recursive calls, maintaining cancellation capability throughout the entire generation lifecycle. Fixes issue where task cancellation fails when maxTurns > 1
Contributor
Author
|
@pavelgj PTAL 🙏 |
Collaborator
|
Good catch. Thanks! |
pavelgj
approved these changes
Sep 8, 2025
hendrixmar
pushed a commit
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generateHelper recursively calls itself during tool iterations, the abortSignal was not being passed to the recursive call. This caused abort signals to be lost after the first tool iteration, preventing proper cancellation of long-running operations with multiple tool calls.
This fix ensures abortSignal is propagated through all recursive calls, maintaining cancellation capability throughout the entire generation lifecycle.
Fixes issue where task cancellation fails when maxTurns > 1
Checklist (if applicable):