refactor(go): moved common types to own package to make registry strongly typed #3492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
approved these changes
Sep 2, 2025
hendrixmar
pushed a commit
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common interfaces like
Action,Plugin,DynamicPluginare now in aapipackage that is used bycore,ai, andregistryso that the registry remains an internal implementation detail but can have strongly typed registration functions, primitives have aRegister(api.Registry)function in their individual interfaces so they can be easily registered after creating, and the interface is public is that custom primitive implementations can be mocked out by third parties.Checklist (if applicable):