-
Notifications
You must be signed in to change notification settings - Fork 623
feat(js): allow naming generates #3416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Missed to commit my change to rename the parameter |
|
Huh, anything I need to do here re python checks? Seems the failed check is unrelated? |
The data model in common is shared across runtimes (js, go and python). There are code generators that handle this stuff. Run (the py script may require uv) |
I see, thank you. That worked and I committed the 2 additional file changes. |
|
It's failing with license checks. When I run it locally it fails as well and running |
must be upstream change in the license checker... can you try adding *.toml to ignore list in Line 60 in 9d5e4ed
|
That worked. Though I had to add toml and nix files |
Implements #3378 custom span names for generate steps. New optional parameter called
stepNamecan be set to define the step name displayed in traces. Will default to "generate" if stepName is not set.Checklist (if applicable):