Skip to content

Conversation

@marcelfolaron
Copy link
Contributor

@marcelfolaron marcelfolaron commented Aug 13, 2025

Implements #3378 custom span names for generate steps. New optional parameter called stepName can be set to define the step name displayed in traces. Will default to "generate" if stepName is not set.

Checklist (if applicable):

@github-actions github-actions bot added the js label Aug 13, 2025
@marcelfolaron marcelfolaron changed the title Named generates Aug 13, 2025
@marcelfolaron marcelfolaron changed the title feat(js) allow naming generates Aug 13, 2025
@marcelfolaron
Copy link
Contributor Author

marcelfolaron commented Aug 14, 2025

Missed to commit my change to rename the parameter name in the testapp to stepName. Should build now

@marcelfolaron
Copy link
Contributor Author

Huh, anything I need to do here re python checks? Seems the failed check is unrelated?
@pavelgj

@pavelgj
Copy link
Collaborator

pavelgj commented Aug 15, 2025

Huh, anything I need to do here re python checks? Seems the failed check is unrelated? @pavelgj

The data model in common is shared across runtimes (js, go and python). There are code generators that handle this stuff.

Run

pnpm build
py/bin/generate_schema_typing

(the py script may require uv)

@marcelfolaron marcelfolaron requested a review from ssbushi as a code owner August 15, 2025 17:28
@github-actions github-actions bot added the python Python label Aug 15, 2025
@marcelfolaron
Copy link
Contributor Author

pnpm build
py/bin/generate_schema_typing

I see, thank you. That worked and I committed the 2 additional file changes.

@marcelfolaron
Copy link
Contributor Author

It's failing with license checks. When I run it locally it fails as well and running ./bin/add_license fixes it. However that adds a lot of license content to quite a few files which seems outside the scope of this PR.

@pavelgj
Copy link
Collaborator

pavelgj commented Aug 15, 2025

It's failing with license checks. When I run it locally it fails as well and running ./bin/add_license fixes it. However that adds a lot of license content to quite a few files which seems outside the scope of this PR.

must be upstream change in the license checker... can you try adding *.toml to ignore list in

-ignore '**/node_modules/**/*' \

@marcelfolaron
Copy link
Contributor Author

It's failing with license checks. When I run it locally it fails as well and running ./bin/add_license fixes it. However that adds a lot of license content to quite a few files which seems outside the scope of this PR.

must be upstream change in the license checker... can you try adding *.toml to ignore list in

-ignore '**/node_modules/**/*' \

That worked. Though I had to add toml and nix files

  -ignore '**/*.toml' \
  -ignore '**/*.nix' \
@pavelgj pavelgj merged commit cc666ba into firebase:main Aug 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants