[Go] support sending images to googleai/vertexai #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The googleai and vertexai API support gs URIs or raw image bytes. The genkit flow doesn't permit raw bytes, so use base64 encoding of data URIs as the TypeScript code does. This revealed that the JSON validation code didn't support Part correctly, as the JSON marshaling didn't match the type as seen by the JSON reflection code. Fortunately the JSON reflection package makes it easy to specify a different schema to use for any type. Somehow menu.jpeg was submitted as an empty file, so fix that.
jba
requested changes
Jun 4, 2024
Contributor
jba
left a comment
jba
left a comment
There was a problem hiding this comment.
Thanks for figuring this out.
jba
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The googleai and vertexai API support gs URIs or raw image bytes. The genkit flow doesn't permit raw bytes, so use base64 encoding of data URIs as the TypeScript code does.
This revealed that the JSON validation code didn't support Part correctly, as the JSON marshaling didn't match the type as seen by the JSON reflection code. Fortunately the JSON reflection package makes it easy to specify a different schema to use for any type.
Somehow menu.jpeg was submitted as an empty file, so fix that.
Description here...
Checklist (if applicable):