fix(go/genkit): add port number to runtime file name #3168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@apascal07 need to test locally, but curious to get your initial thoughts. I ran into this issue in TS, and I'm attempting to port the fixes to Go and Py. 😬 |
apascal07
approved these changes
Jul 8, 2025
MichaelDoyle
force-pushed
the
reflection-port-go
branch
from
806e70f to
952511c
Compare
MichaelDoyle
force-pushed
the
reflection-port-go
branch
3 times, most recently
from
b4d4fdc to
fb6e90a
Compare
If multiple reflection APIs start in quick succession in the same process, the file names can collide. Adding the port number gives it more uniqueness.
MichaelDoyle
force-pushed
the
reflection-port-go
branch
from
fb6e90a to
42336bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple reflection APIs start in quick succession in the same process, the file names can collide. Adding the port number gives it more uniqueness.
Checklist (if applicable):