patch(#3133): added resource name, handle parent resources #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
reviewed
Jun 26, 2025
This commit updates how resources are handled and how metadata is propagated. - Updates `applyResources` to pass the entire resource object instead of just the URI to the resource function. - Updates `defineResource` to accept an optional name, and use the URI or template as the name if not specified. - Updates `defineResource` to propagate resource metadata correctly, including parent information and template information. - Updates tests to reflect the changes in resource handling and metadata propagation.
mbleigh
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (if applicable):