fix: Update metric attribute length truncation to match Trace attribute max length. #3050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistencies between metric data written and trace and log data written making it impossible to correlate data across those products.
…used for Trace attributes.
bryanatkinson
force-pushed
the
ba-metric-attribute-length
branch
from
dbdee62 to
1b7efde
Compare
schnecle
reviewed
Jun 10, 2025
Contributor
schnecle
left a comment
schnecle
left a comment
There was a problem hiding this comment.
Do we need to do anything to the trace attributes as well?
Contributor
Author
They are already being truncated at 256 by default |
schnecle
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute truncation should be consistent between metric data written and trace data written so that data can be correlated between aggregate metric data and specific traces.
Checklist (if applicable):