feat(py/genkit): added the resolve method dummy for vectorstore plugin. #3022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJLazaro
reviewed
Jun 3, 2025
py/plugins/dev-local-vectorstore/src/genkit/plugins/dev_local_vectorstore/plugin_api.py
Outdated
Show resolved
Hide resolved
AbeJLazaro
approved these changes
Jun 3, 2025
pavelgj
reviewed
Jun 4, 2025
py/plugins/dev-local-vectorstore/src/genkit/plugins/dev_local_vectorstore/plugin_api.py
Show resolved
Hide resolved
AbeJLazaro
suggested changes
Jun 9, 2025
Contributor
AbeJLazaro
left a comment
AbeJLazaro
left a comment
There was a problem hiding this comment.
Let's wait this PR for a while
github-actions
bot
added
docs
hendrixmar
force-pushed
the
hendrixmar/feature/resolve_action_vectorstore
branch
from
a8e8036 to
46d8806
Compare
Contributor
|
@hendrixmar is this PR still relevant? |
Contributor
Author
|
Not really |
Contributor
|
@hendrixmar please close it if it is obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a dummy implementation of the resolve method in the vectorstore plugin. The process has been added to satisfy interface requirements for the base plugin base class, which will enable the abstract method for resolve_method in the future.