Skip to content

Conversation

@gioboa
Copy link
Contributor

@gioboa gioboa commented Jun 3, 2025

This commit change the behavior with actions with the same name.
Based on the issue description I changed warnings into errors.

Close #26

Checklist (if applicable):

@gioboa gioboa changed the title feat: throw error with duplicate action key Jun 3, 2025
@MichaelDoyle
Copy link
Member

Hey @gioboa - just checking - it looks like this PR only changes the "log level" from warning to error, and does not actually raise any error. Based on the PR title, though, I think you intend to throw an error?

@gioboa
Copy link
Contributor Author

gioboa commented Jul 7, 2025

Hey @gioboa - just checking - it looks like this PR only changes the "log level" from warning to error, and does not actually raise any error. Based on the PR title, though, I think you intend to throw an error?

Yep, you are right. I fixed the code to get the desired behavior.

@gioboa
Copy link
Contributor Author

gioboa commented Jul 23, 2025

Thanks for your review @MichaelDoyle
I'm looking forward to getting your feedback about the change.

@gioboa gioboa force-pushed the fix-26 branch 2 times, most recently from 13f1f9c to 277aa87 Compare November 12, 2025 08:35
@gioboa gioboa changed the title fix: throw error with duplicate action key Nov 12, 2025
@gioboa
Copy link
Contributor Author

gioboa commented Nov 12, 2025

@pavelgj Can you review this simple change please?

@pavelgj pavelgj merged commit 37fe9de into firebase:main Nov 12, 2025
5 checks passed
@gioboa gioboa deleted the fix-26 branch November 12, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants