Skip to content

chore(js/plugins/{googleai,vertexai}): stop pre-registering gemini 1.0 #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelgj merged 2 commits into from
May 14, 2025
Merged

chore(js/plugins/{googleai,vertexai}): stop pre-registering gemini 1.0 #2910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e73c9a
chore(js/plugins/{googleai,vertexai}): stop preregistering gemini 1.0…
pavelgj May 13, 2025
78219df
Merge branch 'main' into pj/js-stop-preregistering-1.0
pavelgj May 13, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions js/plugins/googleai/src/gemini.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ export const gemini25ProPreview0325 = modelRef({
configSchema: GeminiConfigSchema,
});

export const SUPPORTED_V1_MODELS = {
const SUPPORTED_V1_MODELS = {
'gemini-1.0-pro': gemini10Pro,
};

Expand Down Expand Up @@ -366,7 +366,6 @@ export const GENERIC_GEMINI_MODEL = modelRef({
});

export const SUPPORTED_GEMINI_MODELS = {
...SUPPORTED_V1_MODELS,
...SUPPORTED_V15_MODELS,
} as const;

Expand Down
11 changes: 0 additions & 11 deletions js/plugins/googleai/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ import {
gemini25ProPreview0325,
GeminiConfigSchema,
SUPPORTED_V15_MODELS,
SUPPORTED_V1_MODELS,
type GeminiConfig,
type GeminiVersionString,
} from './gemini.js';
Expand Down Expand Up @@ -121,16 +120,6 @@ async function initializer(ai: Genkit, options?: PluginOptions) {
);
}
if (apiVersions.includes('v1')) {
Object.keys(SUPPORTED_V1_MODELS).forEach((name) =>
defineGoogleAIModel({
ai,
name,
apiKey: options?.apiKey,
apiVersion: undefined,
baseUrl: options?.baseUrl,
debugTraces: options?.experimental_debugTraces,
})
);
Object.keys(SUPPORTED_V15_MODELS).forEach((name) =>
defineGoogleAIModel({
ai,
Expand Down
3 changes: 1 addition & 2 deletions js/plugins/vertexai/src/gemini.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ export const GENERIC_GEMINI_MODEL = modelRef({
},
});

export const SUPPORTED_V1_MODELS = {
const SUPPORTED_V1_MODELS = {
'gemini-1.0-pro': gemini10Pro,
};

Expand All @@ -586,7 +586,6 @@ export const SUPPORTED_V15_MODELS = {
};

export const SUPPORTED_GEMINI_MODELS = {
...SUPPORTED_V1_MODELS,
...SUPPORTED_V15_MODELS,
} as const;

Expand Down