Skip to content

Conversation

@hugoaguirre
Copy link
Contributor

json.NewEncoder() and encoder.Encode() were causing unexpected flushes to the response writer when streaming responses back to the reflection server causing invalid JSONS to be received during the stream execution.

Checklist (if applicable):

@hugoaguirre hugoaguirre requested a review from apascal07 March 28, 2025 16:18
@hugoaguirre hugoaguirre linked an issue Mar 28, 2025 that may be closed by this pull request
@hugoaguirre hugoaguirre marked this pull request as ready for review March 28, 2025 16:18
@hugoaguirre hugoaguirre moved this to In Progress in Genkit Backlog Mar 28, 2025
@apascal07 apascal07 merged commit f2f102b into main Mar 31, 2025
11 checks passed
@apascal07 apascal07 deleted the haguirre/fix-stream-flush branch March 31, 2025 19:21
@github-project-automation github-project-automation bot moved this from In Progress to Done in Genkit Backlog Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants