[Draft]: Vertex AI model garden with OpenAI Compatibility #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
docs
Contributor
|
@zarinn3pal added you to corp CLA. Can you please retrigger the checks? |
yesudeep
requested changes
Mar 18, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/__init__.py
Show resolved
Hide resolved
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/model_garden.py
Show resolved
Hide resolved
...lugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/openai_compatiblility/__init__.py
Show resolved
Hide resolved
...x-ai/src/genkit/plugins/vertex_ai/model_garden/openai_compatiblility/openai_compatibility.py
Show resolved
Hide resolved
Irillit
reviewed
Mar 19, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/modelgarden_plugin.py
Show resolved
Hide resolved
Irillit
reviewed
Mar 19, 2025
py/plugins/vertex-ai/src/genkit/plugins/vertex_ai/model_garden/modelgarden_plugin.py
Show resolved
Hide resolved
Irillit
reviewed
Mar 19, 2025
| def initialize(self, ai: GenkitRegistry) -> None: | ||
| """Handles actions for various openaicompatible models.""" | ||
| for model in self.plugin_options.models: | ||
| openai_model = next( |
Contributor
There was a problem hiding this comment.
Can you just use SUPPORTED_OPENAI_FORMAT_MODELS.get(model)?
Contributor
Author
There was a problem hiding this comment.
you are right. modified it
Irillit
reviewed
Mar 19, 2025
...x-ai/src/genkit/plugins/vertex_ai/model_garden/openai_compatiblility/openai_compatibility.py
Show resolved
Hide resolved
4 tasks
zarinn3pal
force-pushed
the
zarinn3pal/feat/model-garden
branch
from
676f346 to
d3630a2
Compare
Contributor
Author
|
Created a new PR for this , rebasing from recent main,addressing the PR suggestions New PR: #2568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description here... Help the reviewer by:
Added Model garden to vertexAI and implemented openai_compatibility support
linking to an issue that includes more details
if it's a new feature include samples of how to use the new feature
(optional if issue link is provided) if you fixed a bug include basic bug details
Checklist (if applicable):