Skip to content

Conversation

@kirgrim
Copy link
Contributor

@kirgrim kirgrim commented Feb 18, 2025

Description:

  • Added support for action execution context, to make action's callback functions more stateful and flexible

Checklist (if applicable):

@github-actions github-actions bot added feature New feature or request python Python labels Feb 18, 2025
@kirgrim kirgrim force-pushed the hrymailo/feat/support-for-callback-context-in-actions branch 2 times, most recently from 870e931 to 377c263 Compare February 18, 2025 16:22
@timere-nemo
Copy link
Contributor

@kirgrim
I have a general question about the purpose of this context and how it will be used. The ActionExecutionContext includes a general model_config field, which is present in almost every schema. Additionally, it is unclear why certain data needs to be stored within the action itself rather than within the model. If you could provide at least one use case or example, it would help clarify this

@kirgrim
Copy link
Contributor Author

kirgrim commented Feb 19, 2025

@kirgrim I have a general question about the purpose of this context and how it will be used. The ActionExecutionContext includes a general model_config field, which is present in almost every schema. Additionally, it is unclear why certain data needs to be stored within the action itself rather than within the model. If you could provide at least one use case or example, it would help clarify this

reason is that Action is a more generic container which could store entities of different kinds, such as Model. There is no way to persist the model itself inside the registry at the moment, without using Action as a container.

Use case is for Model callback when we need to specify, for instance, output formatting based on version of the passed model data

This will be useful for Ollama and other plugins who after refactor cannot just access the global creation context

@kirgrim kirgrim force-pushed the hrymailo/feat/support-for-callback-context-in-actions branch from 377c263 to ce7bc2f Compare February 20, 2025 11:22
@kirgrim kirgrim force-pushed the hrymailo/feat/support-for-callback-context-in-actions branch from ce7bc2f to 7333339 Compare February 21, 2025 09:33
@kirgrim kirgrim force-pushed the hrymailo/feat/support-for-callback-context-in-actions branch from 7333339 to f3b5dca Compare February 21, 2025 09:42
@kirgrim kirgrim closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request python Python

5 participants