Docs/firebase fixes #177
Merged
Docs/firebase fixes #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthecheung
approved these changes
May 15, 2024
…at trigger on deploy
MaesterChestnut
force-pushed
the
cc/docFix2
branch
from
68559ef to
7b159fb
Compare
Member
|
This looks good. The question I have going forward is, how to ensure these snippets continue to meet the standard, wrt the firebase linter. |
MichaelDoyle
approved these changes
May 16, 2024
Contributor
Author
|
Good call @MichaelDoyle; I added comments about why the prettier-ignore exists which should help the dev who comes next. I think a more sustainable solution will be to move the snippet code into a different repository that has Firebase ESLint running on it, similar to what Firestore has. @kevinthecheung not sure if we plan on extracting code snippets for Genkit in the future, but I think we have a good case to push us that way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify prettier rules for docs/firebase since Firebase Lint requires strings use doublequotes and no spaces next to curly braces