Skip to content

Make Evaluators plugin work with ESM #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssbushi merged 1 commit into from
May 14, 2024
Merged

Make Evaluators plugin work with ESM #158

ssbushi merged 1 commit into from
May 14, 2024

Conversation

@ssbushi
Copy link
Contributor

@ssbushi ssbushi commented May 14, 2024 •
edited
Loading

@ssbushi ssbushi requested review from pavelgj and schnecle May 14, 2024 15:44
@ssbushi ssbushi mentioned this pull request May 14, 2024
Closed
@pavelgj
Copy link
Collaborator

pavelgj commented May 14, 2024

Can you please double check that it still works properly with CJS?
@ssbushi
Copy link
Contributor Author

ssbushi commented May 14, 2024

Yup, I tested it using the DevUI. Works!
@ssbushi ssbushi merged commit 3a2c848 into main May 14, 2024
@ssbushi ssbushi deleted the sb/fixEsm branch May 14, 2024 17:12
@ssbushi ssbushi mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ssbushi @pavelgj